V2 Wizard - Foundations #1531
Merged
V2 Wizard - Foundations #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 69 69
Lines 2035 2035
Branches 560 560
=======================================
Hits 1581 1581
Misses 413 413
Partials 41 41 Continue to review full report in Codecov by Sentry.
|
lucasgarfield
force-pushed
the
v2wiz-foundation
branch
from
bc4b52d to
a933812
Compare
regexowl
approved these changes
Jan 8, 2024
To make code reviews easier, these files are being removed for now. They will be added back over time in a way that results in clearer diffs.
The tests have been converted from .js to .tsx and all lines have been commented out. As steps are added to the wizard, the relevant lines will be uncommented. The V2 wizard can be considered finish when all commented lines have been removed. Proceeding this way (as opposed to starting with an empty test file and adding tests back) will help us ensure we do not accidently 'drop' a test.
The V2 wizard's state will be managed using RTK. Adding a slice for the wizard lays the groundwork.
Adds the scaffolding for the V2 wizard, only empty Image output and Review steps present at this time.
Uncomment all tests that should be passing up to this point in the V2 wizard development.
regexowl
force-pushed
the
v2wiz-foundation
branch
from
a933812 to
8a6fc07
Compare
|
/retest |
I'd love to get rid of as much scss as possible, but I don't want to get blocked on it. But we can do a follow-up PR, could be a good one for @mgold1234 to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR set the foundation for using RTK to manage the state of the V2 wizard.